Set registry.normalizeFullName to resolver.normalize.
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgeb
changed the title
registry.normalizeFullName to resolve.normalize.registry.normalizeFullName to resolver.normalize.
When the `Registry` is present, its `normalizeFullName` method should be set to the resolver's `normalize` method. Overriding the normalize methods on the container is ineffective because they need to proxy to the associated registry's methods.
dgeb
force-pushed
the
isolated-container-registry
branch
from
6a55a80 to
071d6f3
Compare
rwjblue
added a commit
that referenced
this pull request
Mar 11, 2015
Set `registry.normalizeFullName` to `resolver.normalize`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
Registryis present, itsnormalizeFullNamemethod should beset to the resolver's
normalizemethod.Overriding the normalize methods on the container is ineffective because
they need to proxy to the associated registry's methods.