Continue to flesh out more tests for new API's. #224
Conversation
Carries over many tests from the previous (now "legacy-0-6-x" suite) into the new system. This is largely to ensure that the regressions previously caught by these tests, are still checked for long after the legacy-0-6-x suite is gone.
rwjblue
force-pushed
the
add-more-tests-for-new-api
branch
from
698b87b to
61a92aa
Compare
tests/unit/setup-context-test.js
Outdated
| let subject = context.owner.lookup('service:Foo'); | ||
|
|
||
| assert.equal(subject.someMethod(), 'hello thar!'); | ||
| }); |
There was a problem hiding this comment.
should we test this.inject('foo') here too?
There was a problem hiding this comment.
Well, that API is no longer present (see examples and reasoning in the RFC), but I will add an example to both these tests and the rendering tests that will be a better demo of the go forward way to do it...
tests/unit/setup-context-test.js
Outdated
| }) | ||
| ); | ||
|
|
||
| let subject = context.owner.lookup('service:Foo'); |
There was a problem hiding this comment.
I suppose the uppercase Foo was deliberate? could probably use a comment in that case
There was a problem hiding this comment.
Haha, nope, not intentional. Will fix.
| await this.render(hbs`{{x-foo}}`); | ||
|
|
||
| assert.equal(this.element.textContent, 'Click me!', 'precond - component was rendered'); | ||
| click(this.element.querySelector('button')); |
There was a problem hiding this comment.
I assume at some point passing in just a CSS selector will also be supported?
There was a problem hiding this comment.
Ya, these event helpers are only internal test things for now. My next RFC will be for adding the real ones here (and they will essentially have the same API as ember-native-dom-helpers).
There was a problem hiding this comment.
would that mean deprecating ember-native-dom-helpers?
There was a problem hiding this comment.
I don’t know, but possibly. The main differences from what we need here is that we do not want to defer to Ember’s own internal application test globals. It’s definitely possible to do this transition a number of ways...
| input.value = '1'; | ||
|
|
||
| fireEvent(input, 'change'); | ||
| assert.equal(this.get('value'), '1'); |
There was a problem hiding this comment.
precondition assertion might make sense here
| await this.clearRender(); | ||
|
|
||
| assert.equal(this.get('foo'), 'updated!'); | ||
| assert.equal(this.get('bar'), 'updated bar!'); |
There was a problem hiding this comment.
why two properties? because one of them is rendered and the other is not? might need a comment 🤔
Carries over many tests from the previous (now "legacy-0-6-x" suite) into the new system. This is largely to ensure that the regressions previously caught by these tests, are still checked for long after the legacy-0-6-x suite is gone.