Fix regression related to DOM structure. #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that `this.$()` from within a test represents the same structure as prior versions. Ultimately, I would prefer for `this.$()` to refer to the inner HTML (basically what is rendered by the template provided to `this.render`), but changing the underlying structure is definitely not good without proper messaging (and likely major version bump).
In Ember 1.11 and 1.12 the top level outlet is not (by default) wrapped in a view (causing the fixes from the prior commit to fail).
rwjblue
force-pushed
the
fix-dom-structure
branch
from
5c16d96 to
8801f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that
this.$()from within a test represents the same structure as prior versions.Ultimately, I would prefer for
this.$()to refer to the inner HTML (basically what is rendered by the template provided tothis.render), but changing the underlying structure is definitely not good without proper messaging (and likely major version bump).Fixes #159.