Add support for Ember Test registered waiters to wait helper #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +43,10 @@ export default function wait(_options) { | |||
| return; | |||
| } | |||
|
|
|||
| if (waitForWaiters && (Ember.Test.waiters && Ember.Test.waiters.any(([context, callback]) => !callback.call(context)))) { | |||
There was a problem hiding this comment.
Can you structure this to be multiple lines?
adamjmcgrath
force-pushed
the
check-ember-test-waiters
branch
from
746b071 to
39fe6b2
Compare
rwjblue
added a commit
that referenced
this pull request
Jan 24, 2016
Add support for Ember Test registered waiters to wait helper
|
Awesome, thank you! |
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Ember Test registered waiters (http://emberjs.com/api/classes/Ember.Test.html#method_registerWaiter)
See #139