-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ember preview types #1272
Use ember preview types #1272
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,20 +60,7 @@ | |
"@glimmer/interfaces": "^0.84.1", | ||
"@glimmer/reference": "^0.84.1", | ||
"@tsconfig/ember": "^1.0.1", | ||
"@types/ember": "~4.0.0", | ||
"@types/ember-resolver": "^5.0.13", | ||
"@types/ember-testing-helpers": "^0.0.4", | ||
"@types/ember__application": "~4.0.5", | ||
"@types/ember__component": "~4.0.8", | ||
"@types/ember__debug": "~4.0.1", | ||
"@types/ember__destroyable": "~4.0.0", | ||
"@types/ember__engine": "~4.0.4", | ||
"@types/ember__object": "~4.0.2", | ||
"@types/ember__polyfills": "~4.0.0", | ||
"@types/ember__routing": "~4.0.7", | ||
"@types/ember__runloop": "~4.0.1", | ||
"@types/ember__service": "~4.0.0", | ||
"@types/ember__test": "~4.0.0", | ||
"@types/jquery": "^3.5.14", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is needed because |
||
"@types/rsvp": "^4.0.4", | ||
"@typescript-eslint/eslint-plugin": "^4.29.0", | ||
"@typescript-eslint/parser": "^4.29.0", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,5 +9,5 @@ | |
"*": ["./types/*"] | ||
} | ||
}, | ||
"include": ["./addon-test-support/**/*.ts", "tests/**/*.ts"] | ||
"include": ["addon-test-support/**/*.ts", "tests/**/*.ts", "types/**/*.ts"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was necessary for the types to see |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,5 +13,6 @@ | |
"types/*" | ||
] | ||
} | ||
} | ||
}, | ||
"include": ["api.ts", "../types/**/*"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was necessary for the types to see |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import 'ember-source/types'; | ||
import 'ember-source/types/preview'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types aren't public and there is a bunch of
EmberObject
andas any
in this file, so I figured leaving@ts-expect-error
was OK...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the best move, yep. We can flag it up for figuring out a non-private-API way of tackling in the future!