Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures CoreOutlet is passed the correct parameters (fixes ember-canary) #1110

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Aug 23, 2021

ember-canary requires template + environment be provided to the view. This seems like a reasonable change, but does require “low level” libraries such as @ember/test-helpers to make some changes.

(Ember PR emberjs/ember.js#19680)


** note: no additional tests required, as ember-canary scenario is broken prior to this changes... in-other words required tests are already part of the test suite **

ember-canary requires `template` + `environment` be provided to the view. This seems like a reasonable change, but does require “low level” libraries such as `@ember/test-helpers` to make some changes.

(Ember PR emberjs/ember.js#19680)
@thoov
Copy link
Member

thoov commented Aug 23, 2021

LGTM

@scalvert scalvert added the bug label Aug 23, 2021
@stefanpenner stefanpenner merged commit bbb684e into master Aug 23, 2021
@stefanpenner stefanpenner deleted the fix-canary branch August 23, 2021 19:12
@scalvert scalvert changed the title [FIX] This fixes ember-canary Ensures CoreOutlet is passed the correct parameters (fixes ember-canary) Aug 23, 2021
stefanpenner added a commit to embroider-build/embroider that referenced this pull request Aug 23, 2021
stefanpenner added a commit to embroider-build/embroider that referenced this pull request Aug 23, 2021
* [fixes #932] fix ember-canary test scenario

description of problem: emberjs/ember.js#19680 (comment)
fix in @ember/test-helpers: emberjs/ember-test-helpers#1110

* [fixes ember-canary/ember-beta] migrate ember-cli-template-lint -> ember-template-lint

Ember-cli-template-lint is deprecated, and now incompatible with ember 4.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants