Bring back {{#in-element}} test in ember-classic
#1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reviewing further we determined that the issue that was causing
the failure with the `{{#in-element` setup is that `insertBefore` is
required in order to force "append" mode. Without `insertBefore` the
rendering engine will actually **clear** the contents of the target
element (which is waht causes the errors we were seeing).
rwjblue
force-pushed
the
bring-back-in-element-test-in-classic
branch
from
36409f7 to
d1cc08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing further with @pzuraq and @krisselden we determined that the issue that was causing the failure with the
{{#in-elementsetup is thatinsertBeforeis required in order to force "append" mode. WithoutinsertBeforethe rendering engine will actually clear the contents of the target element (which is waht causes the errors we were seeing).