Do not register a router service for Ember <1.13 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,13 @@ import { Klass } from 'klassy'; | |||
| import { getResolver } from './test-resolver'; | |||
| import buildRegistry from './build-registry'; | |||
|
|
|||
| function hasEmberVersion(major, minor) { | |||
There was a problem hiding this comment.
Can you move this to its own file? We have a scenario in tests (for closure actions) where we are using a regexp to determine if a given test should run, and this is a much cleaner solution.
Something like /lib/ember-test-helpers/has-ember-version.js?
|
Can you confirm that the test added here failed prior to the changes? |
|
BTW - The failure in Travis is for canary builds and is being tracked in #99. |
mixonic
force-pushed
the
no-router-for-old-men
branch
from
34e13b9 to
efe7690
Compare
|
Confirmed that the only failure here is the one in #99 |
Versions of Ember prior to 1.13 require a full router booted by the app, or no router at all. This ensures they receive no router at all instead of the 1.13-safe one.
mixonic
force-pushed
the
no-router-for-old-men
branch
from
efe7690 to
7df5b66
Compare
rwjblue
added a commit
that referenced
this pull request
Sep 13, 2015
Do not register a router service for Ember <1.13
|
Thank you! |
blimmer
added a commit
to blimmer/ember-cli-example-app-for-github
that referenced
this pull request
Sep 17, 2015
Supposedly fixed with emberjs/ember-test-helpers#100 , but still seeing the same problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of Ember prior to 1.13 require a full router booted by the app, or no router at all. This ensures they receive no router at all instead of the 1.13-safe one. Result is that the link-to helper can be used in Ember 1.11 and 1.12 component tests (unit and integration).
See also these PRs that attempted to fix the issue in Ember:
IMO, it is more appropriate that it be fixed here, since ember-test-helpers is basically dealing with fragile/intimate API surface when it sets up a router in the container.