Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create public API for accessing the root element. #284

Closed
rwjblue opened this issue Dec 23, 2017 · 2 comments
Closed

Create public API for accessing the root element. #284

rwjblue opened this issue Dec 23, 2017 · 2 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Dec 23, 2017

This would essentially be the string argument case of -get-element, but allows other third party DOM helpers to function without needing the this context of the test to be passed in.

@Turbo87
Copy link
Member

Turbo87 commented Dec 24, 2017

how is this different from getContext().element?

@rwjblue
Copy link
Member Author

rwjblue commented Dec 24, 2017

It isn’t, but there is some issues that folks will have to deal with there. For example, if this isn’t a test setup with setupTest, setupRenderingTest, setupApplicationTest (e.g. a plain QUnit test, or a legacy moduleForAcceptance test) doing getContext().element would result in a very obtuse error message (element of undefined or some such).

bendemboski pushed a commit to bendemboski/ember-test-helpers that referenced this issue Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants