Merge pull request #290 from rwjblue/jsdoc-error

Tests: Make valid-jsdoc an error (instead of warning)
emberjs · Dec 29, 2017 · f25ad0f · f25ad0f
2 parents 65d741a + b33e629
commit f25ad0f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -51,7 +51,7 @@ module.exports = {
     {
       files: ['addon-test-support/**/*.js'],
       rules: {
-        'valid-jsdoc': 'warn',
+        'valid-jsdoc': 'error',
       }
     },
   ]

diff --git a/addon-test-support/@ember/test-helpers/dom/fire-event.js b/addon-test-support/@ember/test-helpers/dom/fire-event.js
@@ -23,6 +23,7 @@ const FILE_SELECTION_EVENT_TYPES = ['change'];
   @param {Element} element the element to dispatch the event to
   @param {string} eventType the type of event
   @param {Object} [options] additional properties to be set on the event
+  @returns {Event} the event that was dispatched
 */
 export default function fireEvent(element, eventType, options = {}) {
   if (!element) {