-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable canary test scenario #259
Comments
This was referenced Jul 28, 2021
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 3, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 3, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 3, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 3, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 3, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 3, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 3, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 4, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 4, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
stefanpenner
added a commit
to emberjs/ember-test-helpers
that referenced
this issue
Aug 4, 2021
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently blocked by some test-helper mumbo-jumbo, working on it.
The text was updated successfully, but these errors were encountered: