Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-test-helpers to expose pauseTest / resumeTest #291

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Nov 5, 2017

  • Update to v0.7.0-beta.9
  • Re-export the importable helpers resumeTest and pauseTest
  • Wrap this.pauseTest to properly reset the test timeout (to avoid the
    test from being marked as failed due to timing out while interacting).

Fixes #287

* Update to v0.7.0-beta.9
* Re-export the importable helpers `resumeTest` and `pauseTest`
* Wrap `this.pauseTest` to properly reset the test timeout (to avoid the
  test from being marked as failed due to timing out while interacting).
@rwjblue rwjblue merged commit 8d44365 into master Nov 5, 2017
@rwjblue rwjblue deleted the implement-pause-test branch November 5, 2017 03:55
@azhiv
Copy link

azhiv commented May 8, 2019

this.pauseTest doesn't reset the timeout for me
It looks like assert.timeout(-1) doesn't do the thing when placed inside the body of pauseTest. However the workaround is to manually insert this statement in the beginning of your test. I suppose it has some peculiarities while executing in-between async/awaits and the execution time of an asynchronous test cannot be configured from inside the asynchronous context. It can only be executed in the beginning of the test while the context is synchronous.
My point is that the statement assert.timeout(-1) is useless and its comment is misleading. Any thoughts?

UPD: this.pauseTest works as expected in devmode

@rwjblue
Copy link
Member Author

rwjblue commented May 8, 2019

@azhiv - Would you mind making an issue so we can follow up on this? I agree, we need to rework things a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pauseTest and resumeTest functionality in setupTest.
2 participants