Skip to content
This repository has been archived by the owner on Nov 11, 2017. It is now read-only.

Ember.Select .create, .reopen, .extend do not issue deprecation warnings #7

Merged
merged 1 commit into from
Jun 12, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions tests/unit/select-class-deprecation-is-silenced-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import { module, test } from 'qunit';

import Ember from 'ember';

module('Ember.Select');

test('does not issue deprecation on create', function(assert){
assert.expect(1);

try {
Ember.Select.create();
} catch(e) {
assert.ok(false, `An error was thrown unexpectedly: ${e.message}`);
}

assert.ok(true, 'No deprecation is thrown');
});

test('does not issue deprecation on reopen', function(assert){
assert.expect(1);

try {
Ember.Select.reopen();
} catch(e) {
assert.ok(false, `An error was thrown unexpectedly: ${e.message}`);
}

assert.ok(true, 'No deprecation is thrown');
});

test('does not issue deprecation on extend', function(assert){
assert.expect(1);

try {
Ember.Select.extend();
} catch(e) {
assert.ok(false, `An error was thrown unexpectedly: ${e.message}`);
}

assert.ok(true, 'No deprecation is thrown');
});
4 changes: 2 additions & 2 deletions tests/unit/view-class-deprecation-is-silenced-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Ember from 'ember';

module('Ember.View');

test('doest not issue deprecation on create', function(assert){
test('does not issue deprecation on create', function(assert){
assert.expect(1);

try {
Expand All @@ -16,7 +16,7 @@ test('doest not issue deprecation on create', function(assert){
assert.ok(true, 'No deprecation is thrown');
});

test('doest not issue deprecation on reopen', function(assert){
test('does not issue deprecation on reopen', function(assert){
assert.expect(1);

try {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/view-helper-deprecation-is-silenced-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module('{{view "some-view"}}', {
}
});

test('doest not issue deprecation on invocation', function(assert){
test('does not issue deprecation on invocation', function(assert){
assert.expect(1);

let registry = new Ember.Registry();
Expand Down