Refactor render debug #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than lumping this in with the profile updates, which are for the render performance tab, I started trying to split things out a bit. Hopefully this is step one of many of making this easier to follow!
RobbieTheWagner
changed the title
There was a problem hiding this comment.
I don’t know the code well enough, but I had to look through the code to understand why setting up a queue would give me an instance of a profile manager & what that queue was purposed for.
Maybe consider creating a ProfileQueue singleton that can contain its state & related functions as methods. That singleton could take a profile manager as an arg to instantiate itself.
|
@sivakumar-kailasam that sounds like a good idea, but can we go ahead and get this in first? Trying to do things incrementally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started renaming and commenting things and trying to split things out a bit. Hopefully this is step one of many of making this easier to follow!