Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember and CLI, bump deps, fix some deprecations, general cleanup #955

Merged
merged 18 commits into from
Apr 17, 2019

Conversation

RobbieTheWagner
Copy link
Member

In an attempt to get the tests passing again, I have been updating all the things and fixing deprecations and issues where I can.

@RobbieTheWagner
Copy link
Member Author

@nummi @rwjblue can you please review this when you have a moment? There are a lot of changes, so sorry for that! I am allowing beta failures in Travis, until we can fix the instanceof ComputedProperty stuff in Ember.

{{iframe-picker}}
</div>
<div class="split__panel__bd">
{{side-nav}}
Copy link
Collaborator

@nummi nummi Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{side-nav deprecationCount=deprecationCount}}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Collaborator

@nummi nummi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Only change is passing the deprecation count to the side-nav component in application.hbs.

@nummi nummi self-requested a review April 17, 2019 16:22
@RobbieTheWagner RobbieTheWagner merged commit 412dc4b into master Apr 17, 2019
@RobbieTheWagner RobbieTheWagner deleted the ember-3.9-beta branch April 17, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants