-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ember and CLI, bump deps, fix some deprecations, general cleanup #955
Conversation
app/templates/application.hbs
Outdated
{{iframe-picker}} | ||
</div> | ||
<div class="split__panel__bd"> | ||
{{side-nav}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{side-nav deprecationCount=deprecationCount}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Only change is passing the deprecation count to the side-nav
component in application.hbs
.
In an attempt to get the tests passing again, I have been updating all the things and fixing deprecations and issues where I can.