Remove usage of chainable functions .readOnly() #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabz75
commented
Mar 18, 2019
| init() { | ||
| this._super(...arguments); | ||
| this.set('_channel', new MessageChannel()); | ||
| this.set('_chromePort', this.get('_channel.port1')); |
There was a problem hiding this comment.
I doubled check that no code is setting these two variables and since we expect variables starting with _ we should be good?
| @@ -419,20 +419,6 @@ module('Ember Debug - Object Inspector', function(hooks) { | |||
| assert.equal(serializedComputedProperty.dependentKeys[1], "bar"); | |||
| }); | |||
|
|
|||
| test('Read Only Computed properties mush have a readOnly property', function(assert) { | |||
There was a problem hiding this comment.
This test seems silly as it's just testing core ember stuff. Removing it.
RobbieTheWagner
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950