UI Components Add-On #942
UI Components Add-On #942
Conversation
- used in object inspector when no object is selected
- drag handle - split - list
|
This is awesome work! I'll give it a thorough review this week at some point. Pretty swamped with some other things currently. |
| @import "sidebar_toggle"; | ||
| @import "split"; | ||
| @import "toolbar"; | ||
| @import "warning"; |
There was a problem hiding this comment.
Most of these were moved to the add-on — a few were no longer being used.
| transform: rotate(-90deg); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
All of this was rolled into the disclosure-triangle component
nummi
force-pushed
the
ui-components-addon
branch
from
4a793c5 to
1e81b84
Compare
| </div> | ||
| {{else}} | ||
| -- | ||
| {{/if}} | ||
| {{/list.cell}} | ||
|
|
||
| {{#list.cell class="list__cell_size_small list__cell_value_numeric"}} | ||
| <span class="pill pill--not-clickable pill--small js-view-duration">{{ms-to-time model.value.duration}}</span> |
There was a problem hiding this comment.
No need for the not-clickable class?
There was a problem hiding this comment.
It didn't seen to have any effect. The class name didn't really describe what it did anyway. Also, I just changed the base .pill class to have that "not-clickable" functionality which is just inheriting the parents cursor.
|
|
||
| <div class="divider" aria-hidden="true"></div> | ||
|
|
||
| <div | ||
| class="toolbar__search toolbar__search--small js-container-instance-search" |
There was a problem hiding this comment.
No need for the toolbar__search--small class anymore?
There was a problem hiding this comment.
It only made the search smaller by 25px. ¯_(ツ)_/¯
|
|
||
| isExpanded: false, | ||
|
|
||
| isRight: equal('side', 'right'), |
There was a problem hiding this comment.
No need for this right stuff anymore?
There was a problem hiding this comment.
As far as I can tell we never had a sidebar toggle for the left sidebar. We can add this back if we ever need it.
The goal of this PR is to move as much generic UI logic to another location and keep the main repo for business logic. This is a huge commit so I'll leave comments where I think they will be useful.
Step two could include: more tests and documentation, usage of a component playground like Storybook or Ember CLI Addon Docs.
This will also make life easier if we go down the Inspector Add-ons route.