Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify layout of Routes Tree #938

Merged

Conversation

nummi
Copy link
Collaborator

@nummi nummi commented Jan 31, 2019

(From discussion with @rwjblue and @rwwagner90)

🛠 What Changed

  • Replaced route and controller class names with simple label
    • Users usually do not (and should not) customize the class names for routes and controllers.
  • Removed templates column
    • No functionality lost other than displaying the template name. Same note as above with following convention.
  • Combined routes and controllers column
  • Used a monospaced font in the URL column. I feel like a list of urls like this is easier to scan when everything lines up as best as possible.

❓Question for Reviewers

Does the "Objects" table heading work for you?

🏞 Screenshots

Original screen shot 2019-01-31 at 11 39 44 am
New screen shot 2019-01-31 at 11 39 31 am

@nummi nummi requested review from rwjblue and pbishop16 January 31, 2019 20:15
@nummi
Copy link
Collaborator Author

nummi commented Jan 31, 2019

@pbishop16, I requested your review since you were not part of the original conversation. Thanks :)

@nummi nummi force-pushed the route-tree-simplificationization branch from bf2189a to a5b0b88 Compare January 31, 2019 20:26
- Remove templates column
- Combine routes and controllers column
- Replace route and controller class names with simple label
@nummi nummi force-pushed the route-tree-simplificationization branch from a5b0b88 to 89f3621 Compare February 1, 2019 20:56
@RobbieTheWagner RobbieTheWagner merged commit c398446 into emberjs:master Feb 4, 2019
@nummi nummi deleted the route-tree-simplificationization branch February 4, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants