Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send count if the object is destroyed #884

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Don't send count if the object is destroyed #884

merged 2 commits into from
Nov 28, 2018

Conversation

thorsteinsson
Copy link
Member

Fixes #864.

@thorsteinsson
Copy link
Member Author

This fix worked for me, I wonder why run.cancel is not working in willDestroy. Any ideas @rwwagner90?

@RobbieTheWagner
Copy link
Member

@thorsteinsson I am not sure why it is not working, but doing extra checks to be sure seems fine 👍

@RobbieTheWagner RobbieTheWagner merged commit 5d01cbe into emberjs:master Nov 28, 2018
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this pull request Mar 30, 2022
@thorsteinsson @cyril-sf
Don't send count if the object is destroyed (emberjs#884)
3f9eb40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorsteinsson @RobbieTheWagner