Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use qunit-dom for DOM assertions #790

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Use qunit-dom for DOM assertions #790

merged 1 commit into from
Apr 26, 2018

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 25, 2018

RobbieTheWagner
RobbieTheWagner approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Is qunit-dom the new preferred testing method in ember/ember-cli?

@rwjblue
Copy link
Member

rwjblue commented Apr 26, 2018

Yes, it should be part of the default ember-cli@3.2 blueprint..

@RobbieTheWagner
Copy link
Member

@rwjblue yeah, it is, I just wasn't sure if we should be using it in place of all assert.equals etc.

@RobbieTheWagner RobbieTheWagner merged commit 6aaff11 into emberjs:master Apr 26, 2018
@Turbo87 Turbo87 deleted the qunit-dom branch April 26, 2018 12:28
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this pull request Mar 30, 2022
@Turbo87 @cyril-sf
Use qunit-dom for DOM assertions (emberjs#790)
02b8f11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @rwjblue @RobbieTheWagner