Remove jQuery from app #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also had to switch to a new context menu plugin. This should get us closer to #590
rwjblue
reviewed
Mar 8, 2018
| @@ -14,6 +14,9 @@ module.exports = { | |||
| env: { | |||
| browser: true | |||
| }, | |||
| globals: { | |||
| basicContext: false | |||
There was a problem hiding this comment.
It is the new contextMenu plugin we are using.
| .on(`mouseup.${namespace} mouseleave.${namespace}`, () => { | ||
| this.stopDragging(); | ||
| }); | ||
| document.body.addEventListener(`mousemove.${namespace}`, this._mouseMoveHandler); |
There was a problem hiding this comment.
These also need to be cleaned up inwillDestroy or willDestroyElement
There was a problem hiding this comment.
willDestroyElement calls this.stopDragging(); which has the removeEventListener calls. Did I mess them up?
There was a problem hiding this comment.
Ahh, I see, thank you for explaining!
package.json
Outdated
| @@ -36,6 +36,7 @@ | |||
| "aws-sdk": "^2.3.3", | |||
| "babel-eslint": "^8.2.2", | |||
| "babel-plugin-transform-es2015-modules-amd": "^6.24.0", | |||
| "basiccontext": "^3.5.1" | |||
|
Thanks! Can you please add a screenshot of the new context menu? |
|
@teddyzeenny I added a screenshot 👍 |
locks
approved these changes
Mar 9, 2018
Closed
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Remove jQuery from app Also had to switch to a new context menu plugin. This should get us closer to emberjs#590 * Add missing comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also had to switch to a new context menu plugin. This should get us closer to #590