Update ESLint and enable more rules #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111:20 error 'Namespace' is not defined no-undef
|
|
||
| const EmberDebug = EmberObject.extend({ | ||
|
|
||
| application: null, | ||
| started: false, | ||
|
|
||
| // Using object shorthand syntax here is somehow having strange side effects. | ||
| // eslint-disable-next-line object-shorthand | ||
| Port: Port, |
There was a problem hiding this comment.
What were the side effects? My first guess is because the es6 module is being transpiled before Babel so Port import is being transpiled to Port['default'] before Babel gets the file.
There was a problem hiding this comment.
huh, that might indeed explain things... I've got another PR waiting that ditches the es6module plugin and uses Babel for that like Ember CLI does too. Once that is merged we can remove the comment and use the shorthand syntax.
|
❤️ !!!! |
|
Looks good to me. Is this ready to merge? |
|
@teddyzeenny should be ready to merge from my side. Thanks for the quick review! |
|
Can you squash the ESlint rules into one commit? |
|
@teddyzeenny done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @teddyzeenny