Use brace expansion lint rule #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
approved these changes
May 3, 2020
|
@rwwagner90 do you have an idea about the failing builds ? 🤔 |
|
@ansmonjol try rebasing with master |
|
@ansmonjol I don't think removing the comma to trigger the build is going to do it. Can you please rebase with master? |
|
@rwwagner90 I was up to date with master 😕 |
|
Have different fail now. |
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Enable use-brace-expansion rule * Fix accordion brace expansion * Fix property brace expansion * Fix promise-item brace expansion * Remove comma - aims to retrigger the CI jobs Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that eslint-plugin-ember support that now.
Test and linter are passing so I guess we're good with enabling this rule back.