Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base font size and utility classes #1157

Merged
merged 6 commits into from
Mar 17, 2020
Merged

Base font size and utility classes #1157

merged 6 commits into from
Mar 17, 2020

Conversation

nummi
Copy link
Collaborator

@nummi nummi commented Mar 10, 2020

  • Tailwind uses normalize.css, we should too
  • Set html font-size to 62.5% so 1rem == ~10px; makes rem sizes easier to grok
  • I'll start using the new font-size utility classes in another PR

I've done a lot of clicking around and I don't see any visible changes to the text.

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for continuing to champion this work 😃. It does appear we have at least one failing test. Might need to slightly tweak some numbers to get that passing. Looks like changing 213 to 212 should be sufficient in the test.

@nummi
Copy link
Collaborator Author

nummi commented Mar 15, 2020

Looks like changing 213 to 212 should be sufficient in the test

I have no idea what is happening...

@nummi nummi merged commit 1c4f549 into emberjs:master Mar 17, 2020
@nummi nummi deleted the base-font branch March 17, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants