fix accessing properties of Object Proxy #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also for tracked detection
There was a problem hiding this comment.
@pzuraq @chancancode I defer to you guys on if this is the right approach or not.
pzuraq
approved these changes
Dec 17, 2019
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 1, 2020
* fix access of Object Proxy also for tracked detection * Update object-inspector-test.js
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 5, 2020
* fix access of Object Proxy also for tracked detection * Update object-inspector-test.js
patricklx
added a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* fix access of Object Proxy also for tracked detection * Update object-inspector-test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for tracked detection the calculate CP function was changed to use the getter directly.
Which does not work on EmberProxies