Tidy up Promise tab #1038
Merged
Tidy up Promise tab #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @, this, </>, action, etc.
| @@ -23,26 +23,26 @@ | |||
| <Ui::ToolbarDivider /> | |||
|
|
|||
| <button | |||
| class="{{if noFilter "active"}} toolbar__radio toolbar__radio--first js-filter" | |||
| {{action "setFilter" "all"}} | |||
| class="{{if (eq this.filter "all") "active"}} toolbar__radio toolbar__radio--first js-filter" | |||
| class=(concat "list__cell_main " expandedClass) | ||
| style=labelStyle | ||
| on-click=(action toggleExpand model) | ||
| {{#@list.cell |
There was a problem hiding this comment.
Was this @ on purpose? I suppose it is valid, but looks odd having #@
There was a problem hiding this comment.
It looks terrible :-P. But list is passed in that way, right? Maybe we should get a consult from an expert?
There was a problem hiding this comment.
Does angle bracket syntax work here?
There was a problem hiding this comment.
Nice! That looks much better 😃
app/templates/promise-tree.hbs
Outdated
| @model={{content}} | ||
| @filter={{this.filter}} | ||
| @effectiveSearch={{this.effectiveSearch}} | ||
| @toggleExpand={{fn this.toggleExpand content}} |
There was a problem hiding this comment.
I'm curious why only two of the actions needed content passed?
There was a problem hiding this comment.
I like to keep the components as dumb as possible but maybe consistency should win here.
There was a problem hiding this comment.
If only two need it, that's fine. I just wanted some clarity.
| sendValueToConsole=(action "sendValueToConsole") | ||
| list=list | ||
| }} | ||
| <PromiseItem |
|
code climate 🤷♂ |
RobbieTheWagner
approved these changes
Sep 25, 2019
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Tidy up Promise tab - @, this, </>, action, etc. * Consistent action passing to PromiseItem * Angle bracket for promise table cells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@, this, </>, action,etc.