Add Ember.immediateObserver support #26
Conversation
|
I still need to add Function.prototype support |
|
Yes still need to add a test for this case |
|
@rwjblue Should be good now. |
thoov
force-pushed
the
immediate-observer
branch
from
8556c66 to
fab5d36
Compare
|
Dang, I made a rebase conflict by merging the other PR. |
thoov
force-pushed
the
immediate-observer
branch
from
fab5d36 to
880aa7d
Compare
|
@rwjblue Fixed. We are going to be hitting a bunch of conflicts as they all touch ¯\_(ツ)_/¯ should be good to go |
| const { EmberENV } = config; | ||
|
|
||
| if (EmberENV.EXTEND_PROTOTYPES && EmberENV.EXTEND_PROTOTYPES.Function === true && Ember.immediateObserver) { | ||
| Function.prototype.observesImmediately = Ember.immediateObserver; |
There was a problem hiding this comment.
Can we move this to a vendor file as well? Sorry for not noticing until the last minute :(
vendor/immediate-observer.js
Outdated
| return _Ember.observer.apply(this, arguments); | ||
| } | ||
|
|
||
| const EXTEND_PROTOTYPES = JSON.parse(decodeURIComponent(document.getElementsByName('dummy/config/environment')[0].content)).EmberENV.EXTEND_PROTOTYPES; |
There was a problem hiding this comment.
@rwjblue I thought that global.EmberEnv contains the merged configs. I see the correctly merged content inside of the meta tag but not on the global. Do you know of a way to grab this from within vendor?
There was a problem hiding this comment.
Disregard this. Issue was with https://github.com/ember-cli/ember-disable-prototype-extensions
|
@rwjblue This should be good now |
Related: emberjs/ember.js#15894
Closes #8