wip #9261
Closed
wip #9261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Mar 16, 2024
| @@ -31,6 +31,11 @@ | |||
| "default": "./addon/*.js" | |||
| } | |||
| }, | |||
| "typesVersions": { | |||
| "*": { | |||
| "*": ["./unstable-preview-types/index.d.ts"] | |||
There was a problem hiding this comment.
I noticed that these weren't built, so this won't work
NullVoxPopuli
commented
Mar 16, 2024
| @@ -55,13 +57,13 @@ export class Request extends Component { | |||
|
|
|||
| <template> | |||
| {{#if this.reqState.isLoading}} | |||
There was a problem hiding this comment.
named args must always come after positional args
NullVoxPopuli
commented
Mar 16, 2024
| @@ -23,6 +23,8 @@ export class Throw extends Component { | |||
| <template></template> | |||
| } | |||
|
|
|||
| const and = (x: unknown, y: unknown) => x && y; | |||
There was a problem hiding this comment.
and wasn't defined or imported
See also: emberjs/rfcs#816
|
thanks for poking around! got the branch working and applied the suggestions on gts usage there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes for the release