Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place store on Ember.Route to maintain default store behaviour #7777

Closed
wants to merge 5 commits into from

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer added 🎯 release PR should be backported to release backport-release PR targets the current release branch 🏷️ deprecation labels Nov 24, 2021
@snewcomer snewcomer self-assigned this Nov 24, 2021
@snewcomer snewcomer changed the base branch from master to release November 24, 2021 19:45
@snewcomer snewcomer changed the title Sn/inject store route release Place store on Ember.Route to maintain default store behaviour Nov 24, 2021
@snewcomer snewcomer removed the 🎯 release PR should be backported to release label Nov 24, 2021
@igorT
Copy link
Member

igorT commented Nov 24, 2021

Once we fix the implicit injection deprecation for 3.28 do we still need to do this?

@snewcomer
Copy link
Contributor Author

Bringing our conversation here:

In 4.0, if you are relying in implicit record loading and have ember-data installed and generate a new route (that triggers a store.find b/c it can parse the params), it will break vs. 3.28. We technically deprecated implicit store injection in 3.x and will be improved in emberjs/ember.js#19854.

Do we necessarily want to put the store on the Route still? Are we ok breaking "new" routes? Or is that bad?

@snewcomer
Copy link
Contributor Author

Not reopening b/c only affected items are blueprints.

@snewcomer snewcomer closed this Nov 29, 2021
@snewcomer snewcomer deleted the sn/inject-store-route-release branch November 29, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-release PR targets the current release branch 🏷️ deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants