Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Don't expose the value of a model's attribute in assertions #7370

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

amk221
Copy link
Contributor

@amk221 amk221 commented Nov 4, 2020

First attempt at fixing: #7270

Unresolved questions

Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A test fix and this should be g2g. Thanks for this PR.

@snewcomer snewcomer marked this pull request as ready for review November 24, 2020 00:24
@igorT
Copy link
Member

igorT commented Nov 24, 2020

👍

… because we want to explicitly test DEBUG vs NOT DEBUG, and assertions are stripped in prod
@amk221
Copy link
Contributor Author

amk221 commented Nov 24, 2020

Thanks to @igorT for helping on discord

set(record, 'isArchived', true);
},
/Attempted to set 'isArchived' on the deleted record <person:1>/,
"Assertion does not leak the 'value'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how strict we are with dbl vs single quotes.

Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@igorT igorT merged commit 9b7936a into emberjs:master Nov 30, 2020
@igorT igorT added the 🎯 beta PR should be backported to beta label Nov 30, 2020
igorT pushed a commit that referenced this pull request Dec 1, 2020
* don't expose the value of a model's attribute in production builds
@igorT igorT added the 🏷️ bug This PR primarily fixes a reported issue label Dec 1, 2020
igorT pushed a commit that referenced this pull request Dec 1, 2020
* don't expose the value of a model's attribute in production builds
@runspired runspired removed the 🎯 beta PR should be backported to beta label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants