Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC model] convert api examples to native classes/Octane #7292

Merged
merged 6 commits into from
Dec 10, 2020
Merged

[DOC model] convert api examples to native classes/Octane #7292

merged 6 commits into from
Dec 10, 2020

Conversation

maxwondercorn
Copy link
Contributor

Updated model examples - reference #7256.

Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phenomenal job on this PR and the previous PRs (that were merged)!

packages/model/addon/-private/errors.js Show resolved Hide resolved
packages/model/addon/-private/model.js Outdated Show resolved Hide resolved
packages/model/addon/-private/model.js Outdated Show resolved Hide resolved
packages/model/addon/-private/model.js Outdated Show resolved Hide resolved
packages/model/addon/-private/model.js Outdated Show resolved Hide resolved
packages/model/addon/-private/model.js Outdated Show resolved Hide resolved
packages/model/addon/-private/system/model-for-mixin.ts Outdated Show resolved Hide resolved
@locks
Copy link
Contributor

locks commented Dec 1, 2020

Oops, I mistakenly requested a review. @maxwondercorn do you have some time to address them?

@maxwondercorn
Copy link
Contributor Author

@locks thanks for pinging me. I didn't realize these were out there. Fixes pushed

Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Really great PR. Ppl will surely appreciate this!

@snewcomer snewcomer merged commit cafc3db into emberjs:master Dec 10, 2020
@sandstrom
Copy link
Contributor

awesome @maxwondercorn 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants