Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix availability of properties in createRecord init #5413

Merged
merged 12 commits into from
Apr 4, 2018
Merged

[BUGFIX] Fix availability of properties in createRecord init #5413

merged 12 commits into from
Apr 4, 2018

Commits on Apr 4, 2018

  1. refactor attr to enable internalModel to set dirty state directly

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    22d481a View commit details
    Browse the repository at this point in the history

  2. refactor hasMany/belongsTo to enable internal-model to setup dirty state

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    4b32222 View commit details
    Browse the repository at this point in the history

  3. adds a failing test for createRecord with properties

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    64f2db1 View commit details
    Browse the repository at this point in the history

  4. lets begin by just making internal state setup work

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    1cbacd3 View commit details
    Browse the repository at this point in the history

  5. go back to initializing through the record

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    ec2f6df View commit details
    Browse the repository at this point in the history

  6. fix setId behavior on createRecord

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    0739672 View commit details
    Browse the repository at this point in the history

  7. make it all work

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    74476c8 View commit details
    Browse the repository at this point in the history

  8. refactor implementation to not mutate properties

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    5fbbfab View commit details
    Browse the repository at this point in the history

  9. expand test ensuring that properties passed to createRecord are not m… 

    …utated
    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    684f10b View commit details
    Browse the repository at this point in the history

  10. add additional test coverage

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    ba094ee View commit details
    Browse the repository at this point in the history

  11. fix tests for findRecord by making snapshot lazily call getRecord if … 

    …possible, skip test that should have never worked but also improve it so that we can maybe make it work in the future
    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    d578710 View commit details
    Browse the repository at this point in the history

  12. address failing test post-rebase

    @runspired
    runspired committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    de55378 View commit details
    Browse the repository at this point in the history