fix notifyPropertyChange error causing backtracking re-render error #5042
Conversation
for async relationships referenced in templates - works with json api adapter - works w/ django rest adapter - works active-model-adapter
eriktrom
force-pushed
the
bugfix/async-rerender-error
branch
from
37a3c60 to
ce40b9b
Compare
…async-rerender-error * 'master' of https://github.com/emberjs/data: update deps add test for hasMany + addObject + destroyRecord more cleanup cleanup update `ember-resolver` `loader.js` `rsvp`
|
@stefanpenner - related and seems important note - our app has issues when the dependent key inside a model is the hasMany relationships live record array - i believe that the attempt to reduce change events from these 2 commits is the root cause: in this pr I tried hard to go with the flow of 'perf ED' - i started by reverting commits - then got this working (for re-renders at least) with no perf loss.. (i believe, big claim, hehe) however, I'm worried about the side effects that apps like ours might run into for edge cases, especially when they go slightly outside the lines of 'ideal'. If upgrading becomes a risk.. i'll drop into dev-ember-data - say friday after lunch - can show u the codez... and have bandwidth to help move this forward - as example, one flow that does not use a dependent key on a hasMany live record array works, the other, boom. Also, save/destroyRecord/change route/save (w/ same id) goes boom too, which made me laugh out loud. unloadRecord also has a bug, un-related to 2.14, came in via 2.13... tl;dr - after a scare this morning, prior to showing the app to a potential customer, we're on 2.12 - so down to fix it w/ u fyi, cheerio |
|
let me know if this is merge ready, i'll rebase to include only the first commit |
|
@eriktrom I believe we want to do some root-cause-analysis on this. Your tests look to be addressing something similar to what @stefanpenner addressed in #5048, could be related. The additional run-loops here only hide the issue, they won't solve it. A couple of questions:
|
yeah, that's pretty much what i figured... and why i left it as Ember.run.join, instead of the de-structured way, for example
Regarding further investigation - let me go back through, i'll write a failing test(s) and we can go from there. I'll keep working off master to ensure it's not already fixed. Thanks. |
|
closing in favor of a root cause analysis fix |
for async relationships referenced in templates
fixes #4942
cc @stefanpenner @runspired (i believe u 2 have the most context on this)