Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the pnpm-lock.yaml #1944

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

NullVoxPopuli
Copy link
Contributor

RFC: emberjs/rfcs#907
Implementation PR: ember-cli/ember-cli#10287
Advancement: emberjs/rfcs#932

Brings pnpm up to the same amount of relevance in the guides as yarn.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit f2936cf
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/64e381531ec5700008a7e658
😎 Deploy Preview https://deploy-preview-1944--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@locks locks enabled auto-merge July 25, 2023 00:40
@locks locks merged commit 3395d89 into ember-learn:master Aug 21, 2023
4 checks passed
@kategengler
Copy link
Contributor

This PR was merged and released and I see it live on the 5.2 version of the guides, however, the feature itself will not be released until 5.3 😬

@jenweber
Copy link
Contributor

jenweber commented Sep 2, 2023

Oops! I saw it was implemented & merged, and didn't look for the next RFC stage. I think it can stay for now, since it's an "or" sort of statement and it will be in a release shortly. Does that sound alright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants