Minimum 3.x series for ember-data addon #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -143,7 +143,7 @@ | |||
| "release-it-lerna-changelog": "^2.3.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "ember-data": "2.x - 3.x", | |||
| "ember-data": "3.x", | |||
There was a problem hiding this comment.
I think we should do >= 3.0.0, but not sure. I would want it to work with 4.x too later potentially.
RobbieTheWagner
approved these changes
Sep 8, 2020
|
Great! Thx for the review. Possible we can get a 0.10 release before this goes in? |
|
@snewcomer sure, I can do another release before this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #552
I am unsure if peer dependencies is a strict versio or loose range. Might be worthwhile to make it
3.x - and aboveif so.