Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse: null to hasMany relationships #1477

Conversation

Shishouille
Copy link
Contributor

This is an attempt to fix #1466 and allow us to add ember-cli-addon-docs with Ember 5.* 😄

@Shishouille Shishouille changed the title Add inverse: null to hasMany relationships Add inverse: null to hasMany relationships Aug 21, 2023
@Shishouille
Copy link
Contributor Author

Seems like the check doesn't pass because of the node version ; so I upgraded it to 18 if it's no bother

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR!

config/ember-try.js Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@RobbieTheWagner
Copy link
Member

FYI, I am updating and fixing a lot of things in #1478

@RobbieTheWagner RobbieTheWagner merged commit 64d2503 into ember-learn:master Aug 22, 2023
@Shishouille
Copy link
Contributor Author

Thanks @RobbieTheWagner! Just checked the PR, looks promising 🙂

@Shishouille Shishouille deleted the fix/add-inverse-null-to-has-many branch August 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ember Data deprecation
2 participants