Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no implicit this deprecation in docs-demo component #1108

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

nickschot
Copy link
Contributor

There was a missing this in the DocsDemo component making it fail to compile with ember-source v4+.

@RobbieTheWagner
Copy link
Member

@nickschot I think this should be @class, but I'm not 100% sure. I don't see class defined in the JS for the component though.

@nickschot
Copy link
Contributor Author

Both works for classic components 😅 I'm fine with either here.

@RobbieTheWagner RobbieTheWagner merged commit 0e83ffa into ember-learn:master Feb 1, 2022
@miguelcobain
Copy link
Collaborator

Would be nice to see this released for all of those wanting to use addon-docs with ember 4+. :D

@RobbieTheWagner
Copy link
Member

@miguelcobain hmm, I am pretty sure I have passing tests for all my addons using addon docs, so it's odd that I am not seeing this. Happy to do a release though

@RobbieTheWagner
Copy link
Member

4.2.2 has been released

@miguelcobain
Copy link
Collaborator

Well, the tests pass with ember 4, that's true.
I was referring to running the dummy app with ember 4. I got runtime errors because of this (I believe this was the cause).

@nickschot
Copy link
Contributor Author

Yep! Same. There's more stuff to update, but as far as I could see this was the only really breaking thing for running the dummy app.

@nickschot nickschot deleted the patch-1 branch February 8, 2022 08:51
@RobbieTheWagner
Copy link
Member

@miguelcobain @nickschot I would love help updating the docs to be angle bracket and anything else you might see that needs updating, if you have the time ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants