Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds ember-keyboard rfc #640

Merged
merged 5 commits into from
May 8, 2020
Merged

adds ember-keyboard rfc #640

merged 5 commits into from
May 8, 2020

Conversation

jaredgalanis
Copy link
Member

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label May 8, 2020
ijlee2
ijlee2 approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of minor suggestions. Thanks for writing again this week!

jaredgalanis and others added 2 commits May 8, 2020 17:25
@jaredgalanis @ijlee2
Update source/2020-05-08-the-ember-times-issue-147.md
8cd8176 
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis @ijlee2
Update source/2020-05-08-the-ember-times-issue-147.md
a508f34 
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis jaredgalanis merged commit 958744a into blog/embertimes-147 May 8, 2020
@jaredgalanis jaredgalanis deleted the add-ember-keyboard-rfc branch May 8, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredgalanis @ijlee2