Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pzuraq reactivity blog posts #529

Merged
merged 8 commits into from
Feb 14, 2020
Merged

Pzuraq reactivity blog posts #529

merged 8 commits into from
Feb 14, 2020

Conversation

jaredgalanis
Copy link
Member

adds the first two blog posts.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Feb 14, 2020
@jaredgalanis jaredgalanis changed the base branch from master to blog/embertimes-135 February 14, 2020 16:16
ijlee2
ijlee2 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reading and covering both articles! I left a few suggestions that I thought would help a reader understand your points.

jaredgalanis and others added 4 commits February 14, 2020 13:23
@jaredgalanis @ijlee2
Update source/2020-02-14-the-ember-times-issue-135.md
9ce122e 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis @ijlee2
Update source/2020-02-14-the-ember-times-issue-135.md
6ab745f 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis @ijlee2
Update source/2020-02-14-the-ember-times-issue-135.md
924e878 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis @ijlee2
Update source/2020-02-14-the-ember-times-issue-135.md
df569ff 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis
Copy link
Member Author

Thanks for reading and covering both articles! I left a few suggestions that I thought would help a reader understand your points.

Thank you @ijlee2 ! All looked good to me so I committed the suggestions.

jaredgalanis and others added 3 commits February 14, 2020 13:25
@jaredgalanis @ijlee2
Update source/2020-02-14-the-ember-times-issue-135.md
a14ca69 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis @ijlee2
Update source/2020-02-14-the-ember-times-issue-135.md
3e4ca85 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jaredgalanis
add blank line to list
f815b6a
@jaredgalanis jaredgalanis merged commit cc392ad into blog/embertimes-135 Feb 14, 2020
@jaredgalanis jaredgalanis deleted the pzuraq-reactivity-blog-posts branch February 14, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinThaMie MinThaMie MinThaMie approved these changes

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredgalanis @MinThaMie @ijlee2