Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog(embertimes#135): add writeup about splarguments RFC #528

Merged
merged 5 commits into from
Feb 14, 2020

Conversation

jayjayjpg
Copy link
Contributor

What it does

Related Issue(s)

Sources

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Feb 14, 2020
@jayjayjpg jayjayjpg requested a review from a team February 14, 2020 13:09
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think we may want to indicate in the title that this is an RFC and not an actual feature yet.

jayjayjpg and others added 3 commits February 14, 2020 15:46
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jayjayjpg
Copy link
Contributor Author

Looks good to me! I think we may want to indicate in the title that this is an RFC and not an actual feature yet.

Good point, I will update that accordingly!

@jayjayjpg
Copy link
Contributor Author

🙇‍♀

@jayjayjpg jayjayjpg merged commit 8bad78c into ember-learn:blog/embertimes-135 Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants