Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Quotes for Ember Times Octane Special #485

Merged

Conversation

jayjayjpg
Copy link
Contributor

@jayjayjpg jayjayjpg commented Jan 10, 2020

Feel free to comment if the post is too loaded with quotes rn and I'll drop the latest commit to only apply the Ember Atlas mention in the learning section / contributors list instead for this week.

What it does

Related Issue(s)

Sources

Screenshot 2020-01-11 at 00 17 35

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 10, 2020
@jayjayjpg jayjayjpg force-pushed the embertimes-jjo2 branch 3 times, most recently from 3120182 to 6292cd4 Compare January 10, 2020 23:06
@jayjayjpg jayjayjpg force-pushed the embertimes-jjo2 branch 2 times, most recently from fa7cfb5 to 54031c0 Compare January 10, 2020 23:13
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! down to merge in

i have some minor edits in #487 can incorporate after this. mainly changing the order, and need to update the ember atlas section

@jayjayjpg jayjayjpg merged commit ac7a974 into ember-learn:blog/embertimes-octane-special Jan 10, 2020
@jayjayjpg jayjayjpg deleted the embertimes-jjo2 branch January 10, 2020 23:19
@jayjayjpg
Copy link
Contributor Author

🙇‍♀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants