Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-data transform docs gives 404 #701

Closed
BryanCrotaz opened this issue Apr 8, 2020 · 12 comments
Closed

ember-data transform docs gives 404 #701

BryanCrotaz opened this issue Apr 8, 2020 · 12 comments

Comments

@BryanCrotaz
Copy link

http://api.emberjs.com/ember-data/release

  1. Select Ember Data 3.17
  2. Click on Transforms link in the side bar.
  3. Get 404 error
@Gaurav0
Copy link
Contributor

Gaurav0 commented Apr 9, 2020

I am unable to reproduce at this time. Also, I am concerned you weren't automatically redirected to https. Let me look into that as well.

@ef4
Copy link

ef4 commented Apr 16, 2020

I'm able to reproduce this, it happens for every link in the list of classes in the sidebar for ember-data.

There's an exception occuring in ember-api-docs/services/meta-store right here:

Screen Shot 2020-04-16 at 10 07 36 AM

The code is trying to access this.projectRevMap["ember-data"] but there is no such key. The only keys are:

["ember-data-3.17.0", "ember-3.17.0"]

@ef4
Copy link

ef4 commented Apr 16, 2020

This only seems to be broken when you're on the latest (currently seeing 3.17). On other versions it works.

@jenweber
Copy link
Contributor

We are not able to reproduce this - can you try again? Also please do a hard refresh and see if the problem persists.

@Gaurav0
Copy link
Contributor

Gaurav0 commented Apr 21, 2020

This may be the same issue as #704 perhaps. @ef4 Can you look at your devtools network tab and see if xhr to https://api-store.emberjs.com failed?

@alexeykostevich
Copy link

alexeykostevich commented Apr 21, 2020

Another possibly related issue is #672.

@alexeykostevich
Copy link

alexeykostevich commented Apr 21, 2020

@jenweber, the issue appears when a user changes the project and then change it back.

Steps to Reproduce:

  1. Open https://api.emberjs.com/ember/release.
  2. Click on Ember Data in Projects.
  3. Click on Ember in Projects.
  4. Click on any item in Packages or Classes.

Expected Result:
The documentation for a selected item should be shown.

Actual Results:
The page shows "Ack! 404 friend, you're in the wrong place". There is an error in a browser console:

TypeError: "this.projectRevMap["".concat(...).concat(...)] is undefined"

Using similar steps, I could reproduce the issue for Ember Data: start from https://api.emberjs.com/ember-data/release and change the project twice.

@BryanCrotaz
Copy link
Author

I can 100% reproduce using @alexeykostevich method

@Gaurav0
Copy link
Contributor

Gaurav0 commented Apr 21, 2020

Thanks. This seems like something we can write a test for and fix!

@jenweber
Copy link
Contributor

This should theoretically be fixed now that #706 is merged. I am going to keep this issue open for comment for a week to confirm that this bug is squashed, so if you see any more 404s, please report them! Thanks everyone who helped out by reporting & debugging!

@alexeykostevich
Copy link

I cannot reproduce the anymore. Great job, @Gaurav0 !

@locks
Copy link
Contributor

locks commented May 26, 2021

Thanks!

@locks locks closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants