Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on Package @ember-data/store giving 404. #672

Open
kyleisuncool opened this issue Mar 11, 2020 · 6 comments
Open

Links on Package @ember-data/store giving 404. #672

kyleisuncool opened this issue Mar 11, 2020 · 6 comments
Assignees

Comments

@kyleisuncool
Copy link

Clicking on push, createRecord, and pushPayload on Package @ember-data/store yields a 404 in 3.16 documentation.

@alexeykostevich
Copy link

@benmurden
Copy link

I am seeing this here, too. Incognito window doesn't resolve it either, unlike in #704.

@Gaurav0
Copy link
Contributor

Gaurav0 commented Apr 27, 2020

I can still reproduce. Must be a separate issue.

@akankshadharkar
Copy link

Any updates on this? I'm facing the same issue today while trying to run the application locally

@ijlee2
Copy link
Member

ijlee2 commented Jul 21, 2020

To provide more information, the links for createRecord, push, and pushPayload do seem to work if we visit the Store class page instead: https://api.emberjs.com/ember-data/release/classes/Store

I haven't looked at the repository code to see how the links for @ember-data/store are created (whether they are hard-coded or automatically generated), but I wondered if the difference between the two pages could give us a starting point for addressing this issue.

@jacobq
Copy link

jacobq commented Jun 2, 2022

FWIW, this is still broken :'( (See also #704 & #801)

I ran into this again today while browsing API docs for ember-data. I clicked the link for createRecord here. The correct/working destination URL has classes/Store/ in the path.

Looking at the JSDoc comment here it looks like the problem may be that the URL is relative (begins with ../), but this link can be viewed from different URLs, e.g. see list below. I've noticed that simply adding/removing the final trailing / can break it.

Broken:

Working:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants