Adds deprecations for event listener functionality #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumar-kailasam
temporarily deployed
to
deprecations-app-stagin-pr-201
pzuraq
force-pushed
the
adds-event-listener-deprecations
branch
from
3a7a465
to
a4f6dd1
Compare
rwjblue
reviewed
Oct 11, 2018
| since: 'Upcoming Features' | ||
| --- | ||
|
|
||
| Currently, function listeners and string listeners are functionally indentical |
There was a problem hiding this comment.
"function listeners" and "functionally" is a super tiny bit confusing to use together, is there another phrasing we can use for the second one?
pzuraq
force-pushed
the
adds-event-listener-deprecations
branch
from
a4f6dd1
to
594db40
Compare
rwjblue
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two deprecations for functionality that we have been rewriting in the event listeners APIs in Ember. The functionality in both cases is obscure, poorly or completely undocumented, and should have very limited real world impact if removed. Both cases cause a fair amount of bloat in terms of actual code and complexity, and removing them would clean up the event listener code by a fair amount.