Remove webpack configuration for externalising react #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since already we use the `@apollo/client/core` import, `react` won't be included in the build. Closes ember-graphql#389
|
This fixes the issue we are experiencing at work, but I know very little about webpack and used @achambers suggestion in #389 to help move this forward. Hope that's ok 😊 |
|
Thank you @bzf. Published in v3.1.1. |
|
I think this is still needed, because if a user imports anything from apollo, like error classes, they run into the error without this config. Maybe the solution is to codemod in the blueprint? And anyone using react can remove it. |
|
@knownasilya there are two alternatives to avoid this issue:
|
|
Seems like you'd have to do both honestly, since there is no great way to enforce where you import from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since already we use the
@apollo/client/coreimport,reactwon't beincluded in the build.
Closes #389