Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options to keep graphql file extension #230

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

josemarluedke
Copy link
Member

No description provided.

@bgentry
Copy link
Member

bgentry commented Jan 28, 2019

Thanks @josemarluedke, the change looks good! Is there an easy way to add a test for this?

@josemarluedke
Copy link
Member Author

@bgentry I was wondering as well how to test it, but couldn't figure it out.

We could change this option to true for the dummy app, but that's not really testing it. In the TS pr, we probably will want to make the option true so we can import the files and TS will be happy with it, but I would leave that for that PR.

@bgentry bgentry merged commit adc0f48 into ember-graphql:master Jan 28, 2019
@josemarluedke josemarluedke deleted the jl-allow-config branch January 28, 2019 23:24
@josemarluedke
Copy link
Member Author

@bgentry Could we get a new release out with the changes in this PR? Thanks.

@bgentry
Copy link
Member

bgentry commented Feb 19, 2019

@josemarluedke well I tried to do this today but my GPG key isn't set up on this machine, will have to wait until later when I'm at home 🤷‍♂️

@bgentry
Copy link
Member

bgentry commented Feb 20, 2019

@josemarluedke v2.0.0-beta.2 released, sorry for the delay ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants