feat: adds a environment variable to opt out of source maps #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielcsapo
force-pushed
the
gabrielcsapo/sourcemaps-opt-out
branch
from
02c9b90 to
2c98637
Compare
gabrielcsapo
force-pushed
the
gabrielcsapo/sourcemaps-opt-out
branch
from
2c98637 to
82cd7f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our initial fix #894 was done internally using patch-package and this solved our memory usage issue. The workaround #895 we had merged in ending up causing an extremely bad CPU spike in production. Because we traded memory usage for cpu because now we constantly read from disk. We want to turn off source maps as we internally unwrap the source and handle this on error in a different system.