Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded fs-extra version to 6.x to fix a fs.copy related issue. #912

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

larry-x-yu
Copy link

@larry-x-yu larry-x-yu commented Feb 7, 2023

fs-extra brought in a breaking change here:
jprichardson/node-fs-extra#582

where it breaks ember-try when copying node_modules/ and there's a symlink in it. The bug would either prevent ember-try from running or cleaning up after try-each.

Testing done:
yarn test passed locally.

@co-authored-by hjdivad

@larry-x-yu larry-x-yu marked this pull request as draft February 7, 2023 21:50
@larry-x-yu larry-x-yu marked this pull request as ready for review February 7, 2023 22:29
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #912 (1618d11) into master (1618d11) will not change coverage.
The diff coverage is n/a.

❗ Current head 1618d11 differs from pull request most recent head e593488. Consider uploading reports for the commit e593488 to get more accurate results

@@           Coverage Diff           @@
##           master     #912   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          17       17           
  Lines         550      550           
=======================================
  Hits          519      519           
  Misses         31       31           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Larry Yu added 3 commits February 8, 2023 10:11
fs-extra brought in a breaking change here:
jprichardson/node-fs-extra#582

where it breaks ember-try when copying node_modules/ and there's
a symlink in it. The bug would either prevent ember-try from
running or cleaning up after try-each.

@co-authored-by hjdivad
@hjdivad
Copy link
Contributor

hjdivad commented Feb 8, 2023

@larry-x-yu i rebased your branch after merging #913

@hjdivad hjdivad added the bug label Feb 8, 2023
@hjdivad
Copy link
Contributor

hjdivad commented Feb 8, 2023

Merging to fix the regression. Longer-term it would be nice to upgrade fs-extra (being sensitive to the breaking change) or otherwise fix up the copying behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants