Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding automatically executed blueprint for config #33

Closed
wants to merge 3 commits into from
Closed

Adding automatically executed blueprint for config #33

wants to merge 3 commits into from

Conversation

thriqon
Copy link

@thriqon thriqon commented Jul 8, 2015

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Jul 8, 2015

Thanks! A few comments:

  • The default config/ember-try.js should match this.
  • We should deprecate usage without a config/ember-try.js present around here

@thriqon
Copy link
Author

thriqon commented Jul 8, 2015

I just updated the PR, addressing your notes, @rwjblue . Did I use Ember.deprecate correctly?

@@ -0,0 +1,29 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add 'use strict'; here?

@kategengler
Copy link
Member

@rwjblue Does ember-cli run the generators for addons that are installed by ember init? If so, should the generated config/ember-try.js for addons be removed from ember-cli?

Also I do not want to deprecate using ember-try without a config. See the proposal in #34

@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

Does ember-cli run the generators for addons that are installed by ember init?

No, it does not. If we want a config/ember-try.js to be generated with ember new, ember addon, or ember init the file has to be in the app or addon blueprints in ember-cli.

I do not want to deprecate using ember-try without a config

Gotcha, totally your call.

@kategengler
Copy link
Member

Gotcha, thanks for the clarification. (It's already in the addon blueprints).

@Turbo87
Copy link
Member

Turbo87 commented Dec 20, 2018

closing due to inactivity

@Turbo87 Turbo87 closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants