Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the resetNamespace option when generating routes #12

Merged
merged 1 commit into from
Oct 5, 2015

Conversation

marcioj
Copy link
Contributor

@marcioj marcioj commented Jun 27, 2015

Since emberjs/ember.js#11517 resource('some route') is deprecated in favor of route('some route', { resetNamespace: true }). This PR enables the resetNamespace option in routeGenerator#add. For instance:

routes.add('foos', { resetNamespace: true })

generates

Router.map(function() {
  this.route('foos', { resetNamespace: true });
});

The idea is to use this option later in the ember-cli route generator via --reset-namespace

@marcioj
Copy link
Contributor Author

marcioj commented Jul 4, 2015

What do you think @stefanpenner @abuiles ?

@marcioj
Copy link
Contributor Author

marcioj commented Oct 5, 2015

Any update here?

abuiles added a commit that referenced this pull request Oct 5, 2015
Enable the resetNamespace option when generating routes
@abuiles abuiles merged commit b314379 into ember-cli:master Oct 5, 2015
@abuiles
Copy link
Member

abuiles commented Oct 5, 2015

@marcioj thanks :) I'll do a release in a bit, can you please upgrade ember-cli docs to document this stuff?

@marcioj marcioj deleted the reset-namespace-option branch October 5, 2015 21:55
@marcioj
Copy link
Contributor Author

marcioj commented Oct 5, 2015

@marcioj thanks :) I'll do a release in a bit, can you please upgrade ember-cli docs to document this stuff?

Sure :). I'll send a PR to ember-cli to include the --reset-namespace option and also add some information about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants